Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 379213002: Added test for two way bindings with strings, ints, and bools. (Closed)

Created:
6 years, 5 months ago by jakemac
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added test for two way bindings with strings, ints, and bools. Previously ints and bools were broken when toggling back and forth. BUG=http://dartbug.com/19692 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38097

Patch Set 1 #

Patch Set 2 : reverting some intermediate changes that accidentally made it through #

Patch Set 3 : ready for review #

Total comments: 2

Patch Set 4 : skip the vm #

Patch Set 5 : code review update #

Total comments: 2

Patch Set 6 : update element names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
M pkg/pkg.status View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/polymer/test/two_way_bind_test.dart View 1 2 3 4 5 1 chunk +88 lines, -0 lines 0 comments Download
A pkg/polymer/test/two_way_bind_test.html View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jakemac
6 years, 5 months ago (2014-07-09 16:49:50 UTC) #1
Siggi Cherem (dart-lang)
https://codereview.chromium.org/379213002/diff/40001/pkg/polymer/test/two_way_bind_test.dart File pkg/polymer/test/two_way_bind_test.dart (right): https://codereview.chromium.org/379213002/diff/40001/pkg/polymer/test/two_way_bind_test.dart#newcode36 pkg/polymer/test/two_way_bind_test.dart:36: var child = parent.shadowRoot.querySelector('my-child-element'); sometimes parent/child confuses me because ...
6 years, 5 months ago (2014-07-09 16:55:49 UTC) #2
jakemac
https://codereview.chromium.org/379213002/diff/40001/pkg/polymer/test/two_way_bind_test.dart File pkg/polymer/test/two_way_bind_test.dart (right): https://codereview.chromium.org/379213002/diff/40001/pkg/polymer/test/two_way_bind_test.dart#newcode36 pkg/polymer/test/two_way_bind_test.dart:36: var child = parent.shadowRoot.querySelector('my-child-element'); On 2014/07/09 16:55:49, Siggi Cherem ...
6 years, 5 months ago (2014-07-09 17:42:16 UTC) #3
Siggi Cherem (dart-lang)
minor comment, but otherwise LGTM https://codereview.chromium.org/379213002/diff/80001/pkg/polymer/test/two_way_bind_test.dart File pkg/polymer/test/two_way_bind_test.dart (right): https://codereview.chromium.org/379213002/diff/80001/pkg/polymer/test/two_way_bind_test.dart#newcode12 pkg/polymer/test/two_way_bind_test.dart:12: class MyChildElement extends PolymerElement ...
6 years, 5 months ago (2014-07-09 17:53:06 UTC) #4
jakemac
https://codereview.chromium.org/379213002/diff/80001/pkg/polymer/test/two_way_bind_test.dart File pkg/polymer/test/two_way_bind_test.dart (right): https://codereview.chromium.org/379213002/diff/80001/pkg/polymer/test/two_way_bind_test.dart#newcode12 pkg/polymer/test/two_way_bind_test.dart:12: class MyChildElement extends PolymerElement { On 2014/07/09 17:53:06, Siggi ...
6 years, 5 months ago (2014-07-09 18:24:47 UTC) #5
Siggi Cherem (dart-lang)
thanks, LGTM
6 years, 5 months ago (2014-07-09 18:32:28 UTC) #6
jakemac
6 years, 5 months ago (2014-07-09 18:35:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #6 manually as r38097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698