Issue 37793004: Switch to lookup declaration by tag name. This fixes issue 14274.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 37793004: Switch to lookup declaration by tag name. This fixes issue 14274. (Closed)

Created:
7 years, 2 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 2 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Switch to lookup declaration by tag name. This fixes issue 14274. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29186

Patch Set 2 : #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -11 lines)			Patch
M	pkg/pkg.status	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/polymer/lib/src/declaration.dart	View		4 chunks	+6 lines, -10 lines	1 comment	Download
M	pkg/polymer/lib/src/instance.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
A	pkg/polymer/test/noscript_test.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
A	pkg/polymer/test/noscript_test.html	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/37793004/diff/70001/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (left): https://codereview.chromium.org/37793004/diff/70001/pkg/polymer/lib/src/declaration.dart#oldcode524 pkg/polymer/lib/src/declaration.dart:524: _registered.add(name); (IIUC _notifySuper is called after the call to ...

7 years, 2 months ago (2013-10-24 02:25:07 UTC) #1

Siggi Cherem (dart-lang)

7 years, 2 months ago (2013-10-24 17:32:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r29186 (presubmit successful).

Expand Messages | Collapse Messages

Issue 37793004: Switch to lookup declaration by tag name. This fixes issue 14274. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages