Issue 377413007: Fix crash for type variables with dynamic bound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 377413007: Fix crash for type variables with dynamic bound. (Closed)

Created:
6 years, 5 months ago by Johnni Winther

Modified:
6 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix crash for type variables with dynamic bound. BUG=http://dartbug.com/19728 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38119

Patch Set 2 : Fix copyright #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View		2 chunks	+3 lines, -2 lines	2 comments	Download
	A +	tests/language/regress_19728_test.dart	View	1	1 chunk	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/377413007/diff/20001/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/377413007/diff/20001/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode17 sdk/lib/_internal/compiler/implementation/dart_types.dart:17: import 'helpers/helpers.dart'; unused.

6 years, 5 months ago (2014-07-10 13:17:27 UTC) #2

Johnni Winther

https://codereview.chromium.org/377413007/diff/20001/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/377413007/diff/20001/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode17 sdk/lib/_internal/compiler/implementation/dart_types.dart:17: import 'helpers/helpers.dart'; On 2014/07/10 13:17:27, floitsch wrote: > unused. ...

6 years, 5 months ago (2014-07-10 13:19:33 UTC) #3

Johnni Winther

6 years, 5 months ago (2014-07-10 13:24:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38119 (presubmit successful).

Expand Messages | Collapse Messages

Issue 377413007: Fix crash for type variables with dynamic bound. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix copyright #

Messages