Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 376693002: Extract testing utilities into a separate package. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Extract testing utilities into a separate package. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38039

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+717 lines, -1159 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
D pkg/analysis_server/test/abstract_context.dart View 1 chunk +0 lines, -89 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_highlights_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_notification_overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 7 chunks +350 lines, -349 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_edit_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/domain_search_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +0 lines, -115 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_analysis_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/package_uri_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 9 chunks +76 lines, -77 lines 0 comments Download
D pkg/analysis_server/test/reflective_tests.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D pkg/analysis_server/test/typed_mocks.dart View 1 chunk +0 lines, -143 lines 0 comments Download
M pkg/analysis_services/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
A + pkg/analysis_testing/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/analysis_testing/lib/abstract_context.dart View 3 chunks +4 lines, -5 lines 0 comments Download
A pkg/analysis_testing/lib/mock_sdk.dart View 1 chunk +128 lines, -0 lines 0 comments Download
A pkg/analysis_testing/lib/mocks.dart View 1 chunk +64 lines, -0 lines 0 comments Download
A + pkg/analysis_testing/lib/reflective_tests.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analysis_testing/pubspec.yaml View 1 chunk +11 lines, -0 lines 0 comments Download
A + pkg/analysis_testing/test/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 2 chunks +4 lines, -3 lines 1 comment Download
M pkg/analyzer/test/index/store/codec_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/index/store/collection_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
A pkg/analyzer/test/index/store/mocks.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/analyzer/test/index/store/separate_file_manager_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/index/store/split_store_test.dart View 2 chunks +14 lines, -10 lines 0 comments Download
D pkg/analyzer/test/index/store/typed_mocks.dart View 1 chunk +0 lines, -143 lines 0 comments Download
D pkg/analyzer/test/reflective_tests.dart View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scheglov
6 years, 5 months ago (2014-07-07 20:25:09 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-07 20:36:34 UTC) #2
scheglov
Committed patchset #1 manually as r38039 (presubmit successful).
6 years, 5 months ago (2014-07-07 20:51:13 UTC) #3
blois
The versions here seem to be incrementing unusually fast, perhaps you can sync with Nathan ...
6 years, 5 months ago (2014-07-11 17:38:38 UTC) #4
nweiz
On 2014/07/11 17:38:38, blois wrote: > The versions here seem to be incrementing unusually fast, ...
6 years, 5 months ago (2014-07-11 18:35:41 UTC) #5
scheglov
6 years, 5 months ago (2014-07-11 19:42:04 UTC) #6
Message was sent while issue was closed.
We started actively working on the analysis server and start hitting some
limitations in analyzer.
So, I usually do a fix in the Java code, make a new translation and publish for
using in the server or the services package.

Thank you for reminding me about -dev, I will use it instead.

Powered by Google App Engine
This is Rietveld 408576698