Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 376593002: Fix name of dart2js full bots to be shorter (Closed)

Created:
6 years, 5 months ago by ricow1
Modified:
6 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix name of dart2js full bots to be shorter R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=38024

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M tools/bots/compiler.py View 1 2 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 5 months ago (2014-07-07 12:55:09 UTC) #1
ricow1
6 years, 5 months ago (2014-07-07 12:56:14 UTC) #2
Bill Hesse
LGTM, with comments. https://codereview.chromium.org/376593002/diff/20001/tools/bots/compiler.py File tools/bots/compiler.py (left): https://codereview.chromium.org/376593002/diff/20001/tools/bots/compiler.py#oldcode27 tools/bots/compiler.py:27: DART2JS_FULL_BUILDER = r'dart2js-full-(linux|mac|windows-ie10|windows-ie11)(-checked)?(-minified)?-(\d+)-(\d+)' Grab the '-' ...
6 years, 5 months ago (2014-07-07 13:02:41 UTC) #3
ricow1
https://codereview.chromium.org/376593002/diff/20001/tools/bots/compiler.py File tools/bots/compiler.py (left): https://codereview.chromium.org/376593002/diff/20001/tools/bots/compiler.py#oldcode27 tools/bots/compiler.py:27: DART2JS_FULL_BUILDER = r'dart2js-full-(linux|mac|windows-ie10|windows-ie11)(-checked)?(-minified)?-(\d+)-(\d+)' On 2014/07/07 13:02:41, Bill Hesse wrote: ...
6 years, 5 months ago (2014-07-07 13:05:43 UTC) #4
ricow1
6 years, 5 months ago (2014-07-07 13:06:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r38024 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698