vm/service/observatory: Add coverage for functions, some tests, and fix buggy filter

BUG=
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38165

[Michael Lippautz (Google), 2014-07-09 23:49:21]

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/coverage.cc#n...
runtime/vm/coverage.cc:182: if (!filter->ShouldOutputCoverageFor(lib, saved_url,
cls, function)) {
We also need to filter within the second loop (that continues looping over
functions in the same source file).

Double-loop is unfortunate, but necessary (?) because of ValueObjects.

[Cutch, 2014-07-10 20:21:06]

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/coverage.cc
File runtime/vm/coverage.cc (right):

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/coverage.cc#n...
runtime/vm/coverage.cc:182: if (!filter->ShouldOutputCoverageFor(lib, saved_url,
cls, function)) {
On 2014/07/09 23:49:21, Michael Lippautz wrote:
> We also need to filter within the second loop (that continues looping over
> functions in the same source file).
> 
> Double-loop is unfortunate, but necessary (?) because of ValueObjects.

Acknowledged.

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1139: if (!GetIntegerId(js->GetArgument(3), &id)) {
Please re-insert the check for num_arguments > 5.

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1161: UNREACHABLE();
I don't like the way this reads. This code can't ever blow up because it can be
triggered over the network. I can see that all paths will return before the
UNREACHABLE but it wigs me out to see it.

[Michael Lippautz (Google), 2014-07-11 16:26:53]

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1139: if (!GetIntegerId(js->GetArgument(3), &id)) {
On 2014/07/10 20:21:06, Cutch wrote:
> Please re-insert the check for num_arguments > 5. 

Done.

https://codereview.chromium.org/376333002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1161: UNREACHABLE();
On 2014/07/10 20:21:06, Cutch wrote:
> I don't like the way this reads. This code can't ever blow up because it can
be
> triggered over the network. I can see that all paths will return before the
> UNREACHABLE but it wigs me out to see it.

As discussed, ignored :)

[Cutch, 2014-07-11 17:35:51]

lgtm

[Michael Lippautz (Google), 2014-07-11 18:39:18]

Committed patchset #3 manually as r38165 (presubmit successful).