Observatory: Promote function to ServiceObject

Observatory: Promote function to ServiceObject

BUG=
R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38105

[Michael Lippautz (Google), 2014-07-09 20:22:25]

ready now, PTAL

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/function_ref.dart (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/function_ref.dart:12: @published
bool qualified = true;
Get rid of 'qualified'?

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/service/object.dart:1270: class Function
extends ServiceObject {
Function clashes with dart.core's Function in the analyzer (which creates
warnings)

Rename?

[Cutch, 2014-07-09 20:43:31]

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/function_ref.dart (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/function_ref.dart:12: @published
bool qualified = true;
On 2014/07/09 20:22:24, Michael Lippautz wrote:
> Get rid of 'qualified'?

We can't, it is used in the html template code.

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/function_view.html (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/function_view.html:115: pos="{{
function.tokenPos }}"
Why the rename from startPos to pos?

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/service/object.dart:1270: class Function
extends ServiceObject {
On 2014/07/09 20:22:24, Michael Lippautz wrote:
> Function clashes with dart.core's Function in the analyzer (which creates
> warnings)
> 
> Rename?

Yes, ServiceFunction, DartFunction, ?

[Michael Lippautz (Google), 2014-07-09 21:02:12]

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/function_ref.dart (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/function_ref.dart:12: @published
bool qualified = true;
On 2014/07/09 20:43:31, Cutch wrote:
> On 2014/07/09 20:22:24, Michael Lippautz wrote:
> > Get rid of 'qualified'?
> 
> We can't, it is used in the html template code.

Misread @published for @observable and did not understand why we would need it.

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/elements/function_view.html (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/elements/function_view.html:115: pos="{{
function.tokenPos }}"
On 2014/07/09 20:43:31, Cutch wrote:
> Why the rename from startPos to pos?

startPos it is.

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/service/object.dart (right):

https://codereview.chromium.org/376293003/diff/100001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/service/object.dart:1270: class Function
extends ServiceObject {
On 2014/07/09 20:43:31, Cutch wrote:
> On 2014/07/09 20:22:24, Michael Lippautz wrote:
> > Function clashes with dart.core's Function in the analyzer (which creates
> > warnings)
> > 
> > Rename?
> 
> Yes, ServiceFunction, DartFunction, ?

ServiceFunction, done.

[Cutch, 2014-07-09 21:04:51]

lgtm

[Michael Lippautz (Google), 2014-07-09 21:32:19]

Committed patchset #7 manually as r38105 (presubmit successful).