Issue 375693005: Skip analysis_services tests in browsers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 375693005: Skip analysis_services tests in browsers. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
siva, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skip analysis_services tests in browsers. TBR R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38048

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r38048 (presubmit successful).

6 years, 5 months ago (2014-07-07 23:39:42 UTC) #2

siva

Could you explain why the analysis services tests fail in the browser and need to ...

6 years, 5 months ago (2014-07-08 00:05:43 UTC) #4

scheglov

6 years, 5 months ago (2014-07-08 00:14:06 UTC) #5

Message was sent while issue was closed.

On 2014/07/08 00:05:43, siva wrote:
> Could you explain why the analysis services tests fail in the browser and need
> to be skipped?

Because some of them reference dart:io library.
Sometimes it is intentional, sometimes accidental.

Expand Messages | Collapse Messages