Issue 375043003: Revert r37059 and dependent r37589. This effectively reduced the size of the getter and setter cach…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 375043003: Revert r37059 and dependent r37589. This effectively reduced the size of the getter and setter cach… (Closed)

Created:
6 years, 5 months ago by rmacnak

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert r37059 and dependent r37589. This effectively reduced the size of the getter and setter caches, exposing http://dartbug.com/18284 in a C1 application. Revert "Implement an LRU cache in dart:_internal and use it for the getter/setter caches in the VM's mirrors." Revert "Use mirror-free LRU test for dart2js" BUG=http://dartbug.com/19909 BUG=http://dartbug.com/18284 BUG=http://dartbug.com/18445 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38076

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -187 lines)			Patch
M	runtime/lib/mirrors_impl.dart	View	5 chunks	+24 lines, -6 lines	0 comments	Download
M	sdk/lib/internal/internal.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/internal/internal_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/internal/lru.dart	View	1 chunk	+0 lines, -125 lines	0 comments	Download
D	tests/compiler/dart2js_native/lru_test.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	tests/lib/mirrors/lru_expect.dart	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	tests/lib/mirrors/lru_test.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

You have to change the status of http://dartbug.com/18445 back. LGTM

6 years, 5 months ago (2014-07-09 00:11:29 UTC) #2

rmacnak

6 years, 5 months ago (2014-07-09 00:18:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r38076 (presubmit successful).

Expand Messages | Collapse Messages