Issue 374413002: Dart2dart rename unresolved getters & Make IsCheck not be a primitive

Issue 374413002: Dart2dart rename unresolved getters & Make IsCheck not be a primitive (Closed)

Created:
6 years, 5 months ago by sigurdm

Modified:
6 years, 5 months ago

Reviewers:
Johnni Winther, floitsch

CC:
reviews_dartlang.org, Kevin Millikin (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dart2dart rename unresolved getters & Make IsCheck not be a primitive R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38113

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -58 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart	View		2 chunks	+2 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart	View	1	1 chunk	+4 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart	View		5 chunks	+16 lines, -23 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/374413002/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/374413002/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode1268 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1268: ir.Primitive isCheck = continueWithExpression( s/isCheck/check

6 years, 5 months ago (2014-07-09 19:24:04 UTC) #2

sigurdm

https://codereview.chromium.org/374413002/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/374413002/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode1268 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1268: ir.Primitive isCheck = continueWithExpression( On 2014/07/09 19:24:03, floitsch wrote: ...

6 years, 5 months ago (2014-07-10 09:03:19 UTC) #3

sigurdm

6 years, 5 months ago (2014-07-10 10:38:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38113 (presubmit successful).

Expand Messages | Collapse Messages