Handle multiline interpolated strings in line-based scanner.

Handle multiline interpolated strings in line-based scanner.

BUG=https://code.google.com/p/dart/issues/detail?id=18601
R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38110

[ahe, 2014-07-07 09:36:55]

https://codereview.chromium.org/373563002/diff/20001/dart/tests/try/paste_con...
File dart/tests/try/paste_content_rewriting_test.dart (right):

https://codereview.chromium.org/373563002/diff/20001/dart/tests/try/paste_con...
dart/tests/try/paste_content_rewriting_test.dart:35: '"\${ [ "\${ [ \'\${ {
\'\${\n{\n} }\' : {\n} } }\' ] }" ] }"',
The best test I have found so far simply ensures that no diagnostics are added
to the above.

[kasperl, 2014-07-07 11:16:39]

LGTM.

https://codereview.chromium.org/373563002/diff/20001/dart/site/try/src/intera...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/373563002/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:1315: // Looking at $identifier.
So token is $ and token.next is the identifier and token.next.next is the
"string" that follows a string interpolation identifier token. Is there a next
too many here? Maybe add a comment if this is correct.

https://codereview.chromium.org/373563002/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:1328: String extractQuote(String
string) {
Would this fit better in the StringQuoting implementation?

https://codereview.chromium.org/373563002/diff/20001/dart/tests/try/paste_con...
File dart/tests/try/paste_content_rewriting_test.dart (right):

https://codereview.chromium.org/373563002/diff/20001/dart/tests/try/paste_con...
dart/tests/try/paste_content_rewriting_test.dart:34: '"\${ [ "\${ [ \'\${ {
\'\${\n{\n} }\' : {\n} } }\' ] }" ] }"':
Add a comment that explains what this is?

[ahe, 2014-07-09 10:11:13]

PTAL

getDecoration has side-effects (setting isMalformedInput) which prevent
compilation from starting. So getDecoration shouldn't be called at all.

https://codereview.chromium.org/373563002/diff/20001/dart/site/try/src/intera...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/373563002/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:1315: // Looking at $identifier.
On 2014/07/07 11:16:39, kasperl wrote:
> So token is $ and token.next is the identifier and token.next.next is the
> "string" that follows a string interpolation identifier token. Is there a next
> too many here? Maybe add a comment if this is correct.

Good catch!

https://codereview.chromium.org/373563002/diff/20001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:1328: String extractQuote(String
string) {
On 2014/07/07 11:16:39, kasperl wrote:
> Would this fit better in the StringQuoting implementation?

Perhaps, but dart2js wouldn't use it.

https://codereview.chromium.org/373563002/diff/20001/dart/tests/try/paste_con...
File dart/tests/try/paste_content_rewriting_test.dart (right):

https://codereview.chromium.org/373563002/diff/20001/dart/tests/try/paste_con...
dart/tests/try/paste_content_rewriting_test.dart:34: '"\${ [ "\${ [ \'\${ {
\'\${\n{\n} }\' : {\n} } }\' ] }" ] }"':
On 2014/07/07 11:16:39, kasperl wrote:
> Add a comment that explains what this is?

Done.

[kasperl, 2014-07-09 10:13:42]

Still LGTM.

[ahe, 2014-07-10 08:39:18]

Committed patchset #2 manually as r38110 (presubmit successful).

[ahe, 2014-07-10 08:39:19]

Thank you, Kasper!