Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 373453002: Revert r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime. Update test st… (Closed)

Created:
6 years, 5 months ago by Bill Hesse
Modified:
6 years, 5 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Revert r37983, "Add periodic browser restart to ContentShellOnAndroid test runtime. Update test status for ContentShellOnAndroid." This reverts CL https://codereview.chromium.org/363323002/ We found that the flaky timeouts are real renderer crashes, and this change does not seem to help. We will instead report more data on the renderer crashes. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=38002

Patch Set 1 #

Patch Set 2 : Restore corrections of typos and status file updates made in r37983, only revert new code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 5 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
6 years, 5 months ago (2014-07-04 09:15:41 UTC) #1
ricow1
lgtm
6 years, 5 months ago (2014-07-04 09:16:23 UTC) #2
Bill Hesse
6 years, 5 months ago (2014-07-04 09:19:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698