Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 372763003: Move file_system libraries into 'analyzer'. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move file_system libraries into 'analyzer'. I still end up including memory FS into 'analyzer' because tests for ResourceUriResolver use it. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -1971 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_directory_manager.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/package_map_provider.dart View 4 chunks +27 lines, -27 lines 0 comments Download
M pkg/analysis_server/lib/src/package_uri_resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/resource.dart View 1 chunk +0 lines, -596 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 2 chunks +17 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/context_directory_manager_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_edit_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_search_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/package_map_provider_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/package_uri_resolver_test.dart View 3 chunks +8 lines, -7 lines 0 comments Download
D pkg/analysis_server/test/physical_resource_provider_test.dart View 1 chunk +0 lines, -293 lines 0 comments Download
D pkg/analysis_server/test/resource_test.dart View 1 chunk +0 lines, -532 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +147 lines, -0 lines 0 comments Download
A + pkg/analyzer/lib/file_system/memory_file_system.dart View 7 chunks +158 lines, -413 lines 0 comments Download
A pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +136 lines, -0 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 2 chunks +2 lines, -1 line 0 comments Download
A + pkg/analyzer/test/file_system/memory_file_system_test.dart View 3 chunks +4 lines, -58 lines 0 comments Download
A + pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 2 chunks +8 lines, -6 lines 0 comments Download
A pkg/analyzer/test/file_system/resource_uri_resolver_test.dart View 1 chunk +64 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/file_system/test_all.dart View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-07 18:12:50 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-07 18:50:12 UTC) #2
scheglov
6 years, 5 months ago (2014-07-07 18:57:55 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r38034 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698