Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 372733003: Closure call inlining for constant closures. (Closed)

Created:
6 years, 5 months ago by Florian Schneider
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Closure call inlining for constant closures. Until now, constant closure functions (e.g. implicit static closures) were not considered as inlining candidates. This CL enables inlining for them. e.g. in code like var f = math.max; f(); the call to f will now be inlined. I changed the source fingerprint computation for implicit closure functions because the signature string of implicit closure functions is different from the parent function's. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M runtime/vm/flow_graph_inliner.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 5 months ago (2014-07-07 15:51:06 UTC) #1
Vyacheslav Egorov (Google)
lgtm
6 years, 5 months ago (2014-07-07 16:19:08 UTC) #2
Florian Schneider
6 years, 5 months ago (2014-07-07 16:22:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698