Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 372193003: fix js_interop_test for browsers without Object.observe (Closed)

Created:
6 years, 5 months ago by Jennifer Messerly
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix js_interop_test for browsers without Object.observe the test assumed Dart timing, which would be next microtask, but since this is a JS element it is updated later. Committed: https://code.google.com/p/dart/source/detail?r=38054

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M pkg/polymer/test/js_interop_test.dart View 1 chunk +10 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
TBR
6 years, 5 months ago (2014-07-08 08:37:07 UTC) #1
Jennifer Messerly
Committed patchset #1 manually as r38054 (presubmit successful).
6 years, 5 months ago (2014-07-08 08:37:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/372193003/diff/1/pkg/polymer/test/js_interop_test.dart File pkg/polymer/test/js_interop_test.dart (right): https://codereview.chromium.org/372193003/diff/1/pkg/polymer/test/js_interop_test.dart#newcode98 pkg/polymer/test/js_interop_test.dart:98: return _onTextChanged(jsElem.shadowRoot).then((_) { could we replace this with: ...
6 years, 5 months ago (2014-07-08 16:50:38 UTC) #3
Jennifer Messerly
6 years, 5 months ago (2014-07-08 18:39:18 UTC) #4
Message was sent while issue was closed.
Thanks Siggi!

https://codereview.chromium.org/372193003/diff/1/pkg/polymer/test/js_interop_...
File pkg/polymer/test/js_interop_test.dart (right):

https://codereview.chromium.org/372193003/diff/1/pkg/polymer/test/js_interop_...
pkg/polymer/test/js_interop_test.dart:98: return
_onTextChanged(jsElem.shadowRoot).then((_) {
On 2014/07/08 16:50:38, Siggi Cherem (dart-lang) wrote:
> could we replace this with:
>   jsElem.onMutation(jsElem.shadowRoot).then
> ?

no, for two reasons:

* jsElem is a JS element so it won't expose onMutation; we'd need .callMethod:
https://github.com/dart-lang/core-elements/issues/45

* onMutation doesn't look for characterData changes, see "characterData: true"
below vs
https://github.com/Polymer/polymer-dev/blob/27b6f83923125d658806a2086543c91e0...

Powered by Google App Engine
This is Rietveld 408576698