Issue 372123002: Get rid of deferred binding for usage errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 372123002: Get rid of deferred binding for usage errors. (Closed)

Created:
6 years, 5 months ago by Bob Nystrom

Modified:
6 years, 5 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get rid of deferred binding for usage errors. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=38102

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -33 lines)			Patch
M	sdk/lib/_internal/pub/lib/src/command.dart	View	4 chunks	+8 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/global_run.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/command/run.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/exceptions.dart	View	1 chunk	+2 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/executable.dart	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/utils.dart	View	1 chunk	+0 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/372123002/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart File sdk/lib/_internal/pub/lib/src/utils.dart (right): https://codereview.chromium.org/372123002/diff/1/sdk/lib/_internal/pub/lib/src/utils.dart#newcode848 sdk/lib/_internal/pub/lib/src/utils.dart:848: void dataError(String message) => throw new DataException(message); Now ...

6 years, 5 months ago (2014-07-08 22:12:48 UTC) #2

Bob Nystrom

Committed patchset #1 manually as r38102 (presubmit successful).

6 years, 5 months ago (2014-07-09 21:04:16 UTC) #3

Bob Nystrom

6 years, 5 months ago (2014-07-09 21:04:29 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/372123002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/372123002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/utils.dart:848: void dataError(String message) =>
throw new DataException(message);
On 2014/07/08 22:12:48, nweiz wrote:
> Now this looks weird again :-/.

Yeah. :-/

Expand Messages | Collapse Messages