Issue 37193002: VM: Fix evaluation order when throwing an AbstractClassInstantiationError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 37193002: VM: Fix evaluation order when throwing an AbstractClassInstantiationError. (Closed)

Created:
7 years, 2 months ago by Florian Schneider

Modified:
7 years, 2 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

VM: Fix evaluation order when throwing an AbstractClassInstantiationError. BUG=https://code.google.com/p/dart/issues/detail?id=13420 TEST=Language/12_Expressions/12_Instance_Creation/1_New_A06_t12 R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=29088

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	runtime/vm/parser.cc	View	1	1 chunk	+13 lines, -6 lines	0 comments	Download
	M	tests/co19/co19-runtime.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/37193002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/37193002/diff/1/runtime/vm/parser.cc#newcode9831 runtime/vm/parser.cc:9831: LetNode * result = new LetNode(call_pos); Extra space ...

7 years, 2 months ago (2013-10-23 14:46:06 UTC) #2

Florian Schneider

Committed patchset #2 manually as r29088 (presubmit successful).

7 years, 2 months ago (2013-10-23 15:29:07 UTC) #3

Florian Schneider

7 years, 2 months ago (2013-10-23 16:31:14 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/37193002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/37193002/diff/1/runtime/vm/parser.cc#newcode9831
runtime/vm/parser.cc:9831: LetNode * result = new LetNode(call_pos);
On 2013/10/23 14:46:06, zra wrote:
> Extra space between LetNode and *

Done.

Expand Messages | Collapse Messages