Issue 371553002: Hide the URIs in minified mode.

Issue 371553002: Hide the URIs in minified mode. (Closed)

Created:
6 years, 5 months ago by floitsch

Modified:
6 years, 5 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Hide the URIs in minified mode. BUG= http://dartbug.com/18903 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=38001

Patch Set 2 : Update comments. #

Total comments: 2

Patch Set 3 : Update comment and remove type annotation that wasn't imported. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	4 chunks	+20 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View		2 chunks	+11 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View		3 chunks	+18 lines, -3 lines	0 comments	Download
A	tests/compiler/dart2js/uri_retention_test.dart	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/371553002/diff/20001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/371553002/diff/20001/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode280 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:280: /// Holds the method "preserveUris" in js_mirrors when ...

6 years, 5 months ago (2014-07-04 07:42:51 UTC) #2

floitsch

Committed patchset #3 manually as r38001 (presubmit successful).

6 years, 5 months ago (2014-07-04 08:45:16 UTC) #3

floitsch

6 years, 5 months ago (2014-07-04 16:33:46 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/371553002/diff/20001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/371553002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:280: /// Holds
the method "preserveUris" in js_mirrors when
On 2014/07/04 07:42:51, Johnni Winther wrote:
> "preserveUri" -> "preserveLibraryNames"

Done.

Expand Messages | Collapse Messages