Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 370743003: Add option to HttpClient to turn of auto uncompression (Closed)

Created:
6 years, 5 months ago by Søren Gjesse
Modified:
6 years, 5 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add option to HttpClient to turn of auto uncompression R=ajohnsen@google.com BUG=http://dartbug.com/19769 Committed: https://code.google.com/p/dart/source/detail?r=38012

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed review copmments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M sdk/lib/io/http.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +4 lines, -1 line 0 comments Download
M tests/standalone/io/http_compression_test.dart View 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
6 years, 5 months ago (2014-07-04 10:34:11 UTC) #1
Anders Johnsen
lgtm https://codereview.chromium.org/370743003/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/370743003/diff/1/sdk/lib/io/http.dart#newcode1243 sdk/lib/io/http.dart:1243: * If the client want to process the ...
6 years, 5 months ago (2014-07-04 10:56:40 UTC) #2
Søren Gjesse
https://codereview.chromium.org/370743003/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/370743003/diff/1/sdk/lib/io/http.dart#newcode1243 sdk/lib/io/http.dart:1243: * If the client want to process the body ...
6 years, 5 months ago (2014-07-04 11:14:01 UTC) #3
Søren Gjesse
6 years, 5 months ago (2014-07-04 12:59:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698