Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 370493002: Fix utility function in smoke, add tests for it. (Closed)

Created:
6 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 5 months ago
Reviewers:
justinfagnani, jakemac, vicb
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix utility function in smoke, add tests for it. R=jakemac@google.com Committed: https://code.google.com/p/dart/source/detail?r=38562

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M pkg/smoke/lib/src/common.dart View 1 1 chunk +15 lines, -3 lines 0 comments Download
A pkg/smoke/test/common_utils_test.dart View 1 2 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Siggi Cherem (dart-lang)
this is to address https://code.google.com/p/dart/issues/detail?id=19471
6 years, 5 months ago (2014-07-03 01:37:42 UTC) #1
vicb
https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart File pkg/smoke/lib/src/common.dart (right): https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart#newcode95 pkg/smoke/lib/src/common.dart:95: } I think that the code is still not ...
6 years, 5 months ago (2014-07-13 09:55:02 UTC) #2
justinfagnani
https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart File pkg/smoke/lib/src/common.dart (right): https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart#newcode95 pkg/smoke/lib/src/common.dart:95: } On 2014/07/13 09:55:02, vicb wrote: > I think ...
6 years, 5 months ago (2014-07-14 17:20:20 UTC) #3
justinfagnani
On 2014/07/14 17:20:20, justinfagnani wrote: > https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart > File pkg/smoke/lib/src/common.dart (right): > > https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart#newcode95 > ...
6 years, 5 months ago (2014-07-14 17:23:31 UTC) #4
vicb
On 2014/07/14 17:23:31, justinfagnani wrote: > A slight optimization: One map of item->count. Calculate it ...
6 years, 5 months ago (2014-07-14 17:39:55 UTC) #5
Siggi Cherem (dart-lang)
https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart File pkg/smoke/lib/src/common.dart (right): https://codereview.chromium.org/370493002/diff/1/pkg/smoke/lib/src/common.dart#newcode95 pkg/smoke/lib/src/common.dart:95: } On 2014/07/14 17:20:19, justinfagnani wrote: > On 2014/07/13 ...
6 years, 5 months ago (2014-07-14 19:48:57 UTC) #6
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-07-23 19:29:11 UTC) #7
jakemac
lgtm https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/lib/src/common.dart File pkg/smoke/lib/src/common.dart (right): https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/lib/src/common.dart#newcode89 pkg/smoke/lib/src/common.dart:89: var count = countMap[x]; putIfAbsent?
6 years, 5 months ago (2014-07-23 20:13:44 UTC) #8
Siggi Cherem (dart-lang)
https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/lib/src/common.dart File pkg/smoke/lib/src/common.dart (right): https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/lib/src/common.dart#newcode89 pkg/smoke/lib/src/common.dart:89: var count = countMap[x]; On 2014/07/23 20:13:44, jakemac wrote: ...
6 years, 5 months ago (2014-07-23 20:30:58 UTC) #9
jakemac
On 2014/07/23 20:30:58, Siggi Cherem (dart-lang) wrote: > https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/lib/src/common.dart > File pkg/smoke/lib/src/common.dart (right): > > ...
6 years, 5 months ago (2014-07-23 20:37:47 UTC) #10
vicb
https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/test/common_utils_test.dart File pkg/smoke/test/common_utils_test.dart (right): https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/test/common_utils_test.dart#newcode34 pkg/smoke/test/common_utils_test.dart:34: expect(compareLists([1, 1, 2, 3, 4, 1], [2, 2, 1, ...
6 years, 5 months ago (2014-07-23 21:23:53 UTC) #11
Siggi Cherem (dart-lang)
https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/test/common_utils_test.dart File pkg/smoke/test/common_utils_test.dart (right): https://codereview.chromium.org/370493002/diff/40001/pkg/smoke/test/common_utils_test.dart#newcode34 pkg/smoke/test/common_utils_test.dart:34: expect(compareLists([1, 1, 2, 3, 4, 1], [2, 2, 1, ...
6 years, 5 months ago (2014-07-25 00:13:20 UTC) #12
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-07-25 00:13:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 manually as r38562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698