Issue 370423002: Hide linter warning for auto-binding-dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 370423002: Hide linter warning for auto-binding-dart. (Closed)

Created:
6 years, 5 months ago by jakemac

Modified:
6 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Hide linter warning for auto-binding-dart. This is special cased for now until we think of a better way to detect elements that are defined only in code. Other elements can be added to the whitelist later as they are discovered. BUG= http://dartbug.com/19809 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38041

Patch Set 1 #

Total comments: 1

Patch Set 2 : add polymer-element to the list and remove from the if #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	pkg/polymer/lib/src/build/linter.dart	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
	M	pkg/polymer/test/build/linter_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm! https://codereview.chromium.org/370423002/diff/1/pkg/polymer/lib/src/build/linter.dart File pkg/polymer/lib/src/build/linter.dart (right): https://codereview.chromium.org/370423002/diff/1/pkg/polymer/lib/src/build/linter.dart#newcode341 pkg/polymer/lib/src/build/linter.dart:341: if (customTagName == null || customTagName == 'polymer-element' ...

6 years, 5 months ago (2014-07-07 21:11:26 UTC) #2

jakemac

6 years, 5 months ago (2014-07-07 21:33:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r38041 (presubmit successful).

Expand Messages | Collapse Messages