Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 37033002: dart:io | Remove uses of Options class from standalone tests. Mark Options deprecated. (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Remove uses of Options class from standalone tests. Mark Options deprecated. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29079

Patch Set 1 #

Patch Set 2 : Remove commented lines from standalone.status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -133 lines) Patch
M sdk/lib/io/options.dart View 1 chunk +9 lines, -2 lines 0 comments Download
M tests/standalone/http_launch_data/http_spawn_main.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/dart_std_io_pipe_script.dart View 1 chunk +8 lines, -9 lines 0 comments Download
M tests/standalone/io/http_cross_process_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/http_server_close_response_after_error_client.dart View 1 chunk +25 lines, -26 lines 0 comments Download
M tests/standalone/io/https_bad_certificate_client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/https_bad_certificate_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/standalone/io/https_unauthorized_client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/https_unauthorized_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/standalone/io/platform_test.dart View 2 chunks +1 line, -11 lines 0 comments Download
M tests/standalone/io/print_env.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_check_arguments_script.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M tests/standalone/io/process_echo_util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/process_std_io_script.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/standalone/io/process_std_io_script2.dart View 1 chunk +7 lines, -8 lines 0 comments Download
M tests/standalone/io/process_sync_script.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M tests/standalone/io/raw_socket_cross_process_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_bad_certificate_client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_bad_certificate_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_builtin_roots_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/standalone/io/secure_unauthorized_client.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_unauthorized_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/socket_cross_process_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/stdin_sync_script.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/test_runner_exit_code_script.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-10-23 11:14:36 UTC) #1
Søren Gjesse
LGTM! This looks much better!
7 years, 2 months ago (2013-10-23 11:17:55 UTC) #2
Bill Hesse
7 years, 2 months ago (2013-10-23 12:50:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r29079 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698