Fix range-analysis.

Fix range-analysis.

BUG= http://dartbug.com/19798
R=kmillikin@google.com, ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38029

[ngeoffray, 2014-07-04 22:36:53]

LGTM, nice catch!

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
File tests/language/range_analysis3_test.dart (right):

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:22: // Give x a range of 0 to 1.
x -> y

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:45: // Give x a range of -1 to 1.
x -> y

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:49: var z = 0;
z is unused in this method.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:50: // Give z a range of 0 to
0 to 0.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:71: // Give x a range of -1 to 1.
x -> y

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:75: var z = 0;
unused z.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:109: // Give x a range of -1 to 1.
x -> y

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:114: // Give z a range of 0 to
unused

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:141: test4a() {
same comments in this method

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:179: test4b() {
ditto

[Kevin Millikin (Google), 2014-07-07 14:23:32]

LGTM.

https://codereview.chromium.org/369833005/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
(right):

https://codereview.chromium.org/369833005/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:888:
static BinaryOperation reverseOperation(BinaryOperation operation) {
To avoid confusion, this could be 'negateOperation'.

https://codereview.chromium.org/369833005/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:902:
static BinaryOperation mirrorOperation(BinaryOperation operation) {
'flipOperation'?  Since mirrors is a thing in Dart.

[floitsch, 2014-07-07 16:02:50]

https://codereview.chromium.org/369833005/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart
(right):

https://codereview.chromium.org/369833005/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:888:
static BinaryOperation reverseOperation(BinaryOperation operation) {
On 2014/07/07 14:23:31, kmillikin wrote:
> To avoid confusion, this could be 'negateOperation'.

Done.

https://codereview.chromium.org/369833005/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart:902:
static BinaryOperation mirrorOperation(BinaryOperation operation) {
On 2014/07/07 14:23:31, kmillikin wrote:
> 'flipOperation'?  Since mirrors is a thing in Dart.

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
File tests/language/range_analysis3_test.dart (right):

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:22: // Give x a range of 0 to 1.
On 2014/07/04 22:36:53, ngeoffray wrote:
> x -> y

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:45: // Give x a range of -1 to 1.
On 2014/07/04 22:36:53, ngeoffray wrote:
> x -> y

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:49: var z = 0;
On 2014/07/04 22:36:53, ngeoffray wrote:
> z is unused in this method.

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:50: // Give z a range of 0 to
On 2014/07/04 22:36:53, ngeoffray wrote:
> 0 to 0.

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:71: // Give x a range of -1 to 1.
On 2014/07/04 22:36:53, ngeoffray wrote:
> x -> y

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:75: var z = 0;
On 2014/07/04 22:36:53, ngeoffray wrote:
> unused z.

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:109: // Give x a range of -1 to 1.
On 2014/07/04 22:36:53, ngeoffray wrote:
> x -> y

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:114: // Give z a range of 0 to
On 2014/07/04 22:36:53, ngeoffray wrote:
> unused

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:141: test4a() {
On 2014/07/04 22:36:53, ngeoffray wrote:
> same comments in this method

Done.

https://codereview.chromium.org/369833005/diff/1/tests/language/range_analysi...
tests/language/range_analysis3_test.dart:179: test4b() {
On 2014/07/04 22:36:53, ngeoffray wrote:
> ditto

Done.

[floitsch, 2014-07-07 16:39:00]

Committed patchset #2 manually as r38029 (presubmit successful).