Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 369573006: Fix assertion in Dartium loading (Closed)

Created:
6 years, 5 months ago by hausner
Modified:
6 years, 5 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix assertion in Dartium loading A library may be marked as “loaded with error” multiple times it it consists of parts. Fix an assertion that caused some tests in Dartium to fail. Fixes issue 19758. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=37958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/object.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 5 months ago (2014-07-02 22:02:13 UTC) #1
regis
LGTM
6 years, 5 months ago (2014-07-02 22:09:08 UTC) #2
hausner
6 years, 5 months ago (2014-07-02 22:09:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37958 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698