Build bits to add an analysis_server snapshot to the SDK.

Build bits to add an analysis_server snapshot to the SDK.

NOTE: as per a conversation with Kasper, this does NOT add any executables to the "bin" dir.  In this state the expectation is that the snapshot will be invoked directly via bin/dart.

R=kustermann@google.com, ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39391

[pquitslund, 2014-07-28 20:28:00]

Ping.

Feedback appreciated!

[kustermann, 2014-07-29 08:43:15]

Looks pretty good to me [with comment], but I'm not deciding what goes into the
SDK. rico/kasperl?

https://codereview.chromium.org/368993002/diff/60001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/368993002/diff/60001/tools/create_sdk.py#newc...
tools/create_sdk.py:116: for snapshot in ['analysis_server', 'dart2js',
'dartanalyzer', 'dartfmt', 'utils_wrapper',
long line

https://codereview.chromium.org/368993002/diff/60001/utils/analysis_server/an...
File utils/analysis_server/analysis_server.gyp (right):

https://codereview.chromium.org/368993002/diff/60001/utils/analysis_server/an...
utils/analysis_server/analysis_server.gyp:21: '<!@(["python",
"../../tools/list_files.py", "\\.dart$", "../../pkg/analysis_server"])',
I think this is not correct. You want to build the analysis_server, but that
package has transitive dependencies. E.g. If the watcher package gets a fix, you
need to rebuild the analysis server as well ...

Conservative solution would be to depend on all dart files in dart/pkg?

[ricow1, 2014-07-29 09:12:44]

Code lgtm with package dependency resolved
Is this something we are aiming at shipping in the 1.6 release?

https://codereview.chromium.org/368993002/diff/60001/utils/analysis_server/an...
File utils/analysis_server/analysis_server.gyp (right):

https://codereview.chromium.org/368993002/diff/60001/utils/analysis_server/an...
utils/analysis_server/analysis_server.gyp:21: '<!@(["python",
"../../tools/list_files.py", "\\.dart$", "../../pkg/analysis_server"])',
On 2014/07/29 08:43:15, kustermann wrote:
> I think this is not correct. You want to build the analysis_server, but that
> package has transitive dependencies. E.g. If the watcher package gets a fix,
you
> need to rebuild the analysis server as well ...
> 
> Conservative solution would be to depend on all dart files in dart/pkg?

You can depend on pkg/pkg_files.gyp and then have the stamp file as input. You
can see how pub or docgen does this

[pquitslund, 2014-08-18 18:35:55]

Cheers!  Updated with fixes.  I'm not 100% confident I interpreted your advice
on deps correctly...  Let me know what you think.

https://codereview.chromium.org/368993002/diff/60001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/368993002/diff/60001/tools/create_sdk.py#newc...
tools/create_sdk.py:116: for snapshot in ['analysis_server', 'dart2js',
'dartanalyzer', 'dartfmt', 'utils_wrapper',
On 2014/07/29 08:43:15, kustermann wrote:
> long line 

Done.

https://codereview.chromium.org/368993002/diff/60001/utils/analysis_server/an...
File utils/analysis_server/analysis_server.gyp (right):

https://codereview.chromium.org/368993002/diff/60001/utils/analysis_server/an...
utils/analysis_server/analysis_server.gyp:21: '<!@(["python",
"../../tools/list_files.py", "\\.dart$", "../../pkg/analysis_server"])',
On 2014/07/29 09:12:44, ricow1 wrote:
> On 2014/07/29 08:43:15, kustermann wrote:
> > I think this is not correct. You want to build the analysis_server, but that
> > package has transitive dependencies. E.g. If the watcher package gets a fix,
> you
> > need to rebuild the analysis server as well ...
> > 
> > Conservative solution would be to depend on all dart files in dart/pkg?
> 
> You can depend on pkg/pkg_files.gyp and then have the stamp file as input. You
> can see how pub or docgen does this
> 

Thanks for the tips!  I *think* I got it right.

Perhaps take another look?

[kustermann, 2014-08-19 07:47:19]

LGTM -- since ricow is on vacation.

https://codereview.chromium.org/368993002/diff/100001/utils/analysis_server/a...
File utils/analysis_server/analysis_server.gyp (right):

https://codereview.chromium.org/368993002/diff/100001/utils/analysis_server/a...
utils/analysis_server/analysis_server.gyp:23: '<!@(["python",
"../../tools/list_files.py", "\\.dart$", "../../pkg/analysis_server"])',
I assume that this line is obsolete, since the pkg_files.stamp file will change
if any of the files in pkg/ change (including pkg/analysis_server)

[pquitslund, 2014-08-19 16:39:32]

https://codereview.chromium.org/368993002/diff/100001/utils/analysis_server/a...
File utils/analysis_server/analysis_server.gyp (right):

https://codereview.chromium.org/368993002/diff/100001/utils/analysis_server/a...
utils/analysis_server/analysis_server.gyp:23: '<!@(["python",
"../../tools/list_files.py", "\\.dart$", "../../pkg/analysis_server"])',
On 2014/08/19 07:47:19, kustermann wrote:
> I assume that this line is obsolete, since the pkg_files.stamp file will
change
> if any of the files in pkg/ change (including pkg/analysis_server)

Quite right.  Obvious to me now. Thanks!

[pquitslund, 2014-08-19 23:22:28]

Committed patchset #7 manually as r39391 (presubmit successful).