Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 368983003: Add better error reporting to utils tests. (Closed)

Created:
6 years, 5 months ago by Johnni Winther
Modified:
6 years, 5 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add better error reporting to utils tests. BUG= R=herhut@google.com Committed: https://code.google.com/p/dart/source/detail?r=37999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M tests/utils/dummy_compiler_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M tests/utils/source_mirrors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
6 years, 5 months ago (2014-07-04 07:16:53 UTC) #1
herhut
lgtm
6 years, 5 months ago (2014-07-04 07:37:43 UTC) #2
Johnni Winther
6 years, 5 months ago (2014-07-04 07:48:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37999 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698