Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 368833002: Cleanup warnings in unit tests. (Closed)

Created:
6 years, 5 months ago by karlklose
Modified:
6 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix outdated type annotations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M tests/compiler/dart2js/bad_output_io_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 1 3 chunks +3 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
6 years, 5 months ago (2014-07-02 09:38:54 UTC) #1
Johnni Winther
LGTM but we should have a test that ensures this.
6 years, 5 months ago (2014-07-02 10:09:57 UTC) #2
karlklose
On 2014/07/02 10:09:57, Johnni Winther wrote: > LGTM but we should have a test that ...
6 years, 5 months ago (2014-07-09 09:28:42 UTC) #3
karlklose
6 years, 5 months ago (2014-07-09 09:29:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698