Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 368433004: Fix overloading for IDBDatabase transaction (Closed)

Created:
6 years, 5 months ago by Leaf
Modified:
6 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix overloading for IDBDatabase transaction Use the underlying dart implementation class in overloading resolution checks, rather than the dart interface which is presented to the user. This resolves an issue with IDBDatabase in which DOMStringList and sequence<DOMString> have the same Dart interface type (List<String>), even though the underlying implementation types differ (List<String> vs DomStringList). BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 2 chunks +8 lines, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Leaf
6 years, 5 months ago (2014-07-01 00:30:59 UTC) #1
vsm
lgtm
6 years, 5 months ago (2014-07-01 04:53:59 UTC) #2
Leaf
6 years, 5 months ago (2014-07-01 17:24:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37883 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698