Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 368383002: Revert revision 38013 and revision 38011 (Closed)

Created:
6 years, 5 months ago by ricow1
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert revision 38013 and revision 38011 They are not working as expected Committed: https://code.google.com/p/dart/source/detail?r=38017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M pkg/polymer/lib/src/build/runner.dart View 1 chunk +1 line, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
6 years, 5 months ago (2014-07-04 14:39:06 UTC) #1
ricow1
Committed patchset #1 manually as r38017 (presubmit successful).
6 years, 5 months ago (2014-07-04 14:39:34 UTC) #2
Bill Hesse
lgtm LGTM.
6 years, 5 months ago (2014-07-04 15:24:50 UTC) #3
aam-me
Conceptually 260 chars filename limitation can be overcome by prefixing filenames with '\\?\': quoting DeleteFunction ...
6 years, 5 months ago (2014-07-05 00:25:42 UTC) #4
Jennifer Messerly
+Siggi. LGTM tho
6 years, 5 months ago (2014-07-06 23:00:00 UTC) #5
Siggi Cherem (dart-lang)
6 years, 5 months ago (2014-07-07 16:51:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698