Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 368363002: dart2dart: Copy propagation in dart_tree. (Closed)

Created:
6 years, 5 months ago by asgerf
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart2dart: Copy propagation in dart_tree. Moving assignments w := v are eliminated by assigning directly to w at the definition of v. Since we can't check if v is live after the assignment, this only clicks when we have the unique use of v. BUG= R=kmillikin@google.com, sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=38008

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix for labeled statements #

Patch Set 3 : Typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -81 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart View 1 2 4 chunks +188 lines, -79 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
asgerf
6 years, 5 months ago (2014-07-04 10:18:16 UTC) #1
Kevin Millikin (Google)
LGTM.
6 years, 5 months ago (2014-07-04 10:37:49 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/368363002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart (right): https://codereview.chromium.org/368363002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart#newcode1732 sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:1732: * nothing no optimization could be performed. if ...
6 years, 5 months ago (2014-07-04 10:56:51 UTC) #3
asgerf
https://codereview.chromium.org/368363002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart File sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart (right): https://codereview.chromium.org/368363002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart#newcode1732 sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart:1732: * nothing no optimization could be performed. On 2014/07/04 ...
6 years, 5 months ago (2014-07-04 10:58:37 UTC) #4
asgerf
6 years, 5 months ago (2014-07-04 10:59:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r38008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698