Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 367973006: Implementation for 'analysis.occurrences' notification. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implementation for 'analysis.occurrences' notification. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +10 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 1 chunk +0 lines, -1 line 0 comments Download
A pkg/analysis_server/lib/src/computer/computer_occurrences.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 4 chunks +8 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 3 chunks +14 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/analysis_notification_occurrences_test.dart View 1 chunk +165 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 4 chunks +8 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-02 18:35:15 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-02 18:37:46 UTC) #2
scheglov
6 years, 5 months ago (2014-07-02 18:38:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37954 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698