Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 367793002: Update Element/navigation/outline to use Location. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update Element/navigation/outline to use Location. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37903

Patch Set 1 #

Patch Set 2 : Forgotten file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -375 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_navigation.dart View 4 chunks +7 lines, -38 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 11 chunks +33 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 7 chunks +74 lines, -23 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 2 chunks +6 lines, -6 lines 0 comments Download
A pkg/analysis_server/test/abstract_context.dart View 1 1 chunk +88 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_navigation_test.dart View 4 chunks +26 lines, -36 lines 0 comments Download
M pkg/analysis_server/test/analysis_notification_outline_test.dart View 26 chunks +130 lines, -52 lines 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 4 chunks +162 lines, -153 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +1 line, -17 lines 0 comments Download
M pkg/analysis_server/test/index/index_test.dart View 4 chunks +8 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-01 19:57:40 UTC) #1
Brian Wilkerson
LGTM
6 years, 5 months ago (2014-07-01 20:24:08 UTC) #2
scheglov
6 years, 5 months ago (2014-07-01 20:25:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r37903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698