Issue 367613003: Revert "Add runtime_data.dart to the whitelist of files with unused members." and "Emit declaration…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 367613003: Revert "Add runtime_data.dart to the whitelist of files with unused members." and "Emit declaration… (Closed)

Created:
6 years, 5 months ago by karlklose

Modified:
6 years, 5 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Add runtime_data.dart to the whitelist of files with unused members." and "Emit declarations for typedefs that are needed by reflection." It does not work in checked mode. This reverts commits 37814 and 37818. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37848

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -146 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View	10 chunks	+21 lines, -49 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart	View	1 chunk	+14 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/_internal/compiler/implementation/runtime_data.dart	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	4 chunks	+25 lines, -26 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_unused_dart2js_test.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/lib/mirrors/relation_subclass_test.dart	View	1 chunk	+7 lines, -6 lines	0 comments	Download
D	tests/lib/mirrors/typedef_declaration_test.dart	View	1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

Committed patchset #1 manually as r37848 (presubmit successful).

6 years, 5 months ago (2014-07-01 07:40:55 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages