Issue 367453003: Handle relative paths in the output of "pub list-package-dirs".

Issue 367453003: Handle relative paths in the output of "pub list-package-dirs". (Closed)

Created:
6 years, 5 months ago by Paul Berry

Modified:
6 years, 5 months ago

Reviewers:
scheglov, jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle relative paths in the output of "pub list-package-dirs". R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=37879

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -18 lines)			Patch
M	pkg/analysis_server/lib/src/package_map_provider.dart	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/resource.dart	View	5 chunks	+25 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/test/package_map_provider_test.dart	View	4 chunks	+37 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/test/physical_resource_provider_test.dart	View	1 chunk	+11 lines, -0 lines	2 comments	Download
M	pkg/analysis_server/test/resource_test.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/367453003/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart File pkg/analysis_server/test/physical_resource_provider_test.dart (right): https://codereview.chromium.org/367453003/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart#newcode251 pkg/analysis_server/test/physical_resource_provider_test.dart:251: expect(folder.canonicalizePath('../folder2'), equals(path2)); Replace '../folder2' with join?

6 years, 5 months ago (2014-07-01 15:33:38 UTC) #2

Paul Berry

https://codereview.chromium.org/367453003/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart File pkg/analysis_server/test/physical_resource_provider_test.dart (right): https://codereview.chromium.org/367453003/diff/1/pkg/analysis_server/test/physical_resource_provider_test.dart#newcode251 pkg/analysis_server/test/physical_resource_provider_test.dart:251: expect(folder.canonicalizePath('../folder2'), equals(path2)); On 2014/07/01 15:33:38, scheglov wrote: > Replace ...

6 years, 5 months ago (2014-07-01 16:31:42 UTC) #3

Paul Berry

6 years, 5 months ago (2014-07-01 16:32:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r37879 (presubmit successful).

Expand Messages | Collapse Messages