Issue 367023003: Roll forward revision 37912.

Issue 367023003: Roll forward revision 37912. (Closed)

Created:
6 years, 5 months ago by nweiz

Modified:
6 years, 5 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Roll forward revision 37912. Both polymer and code_transformers test flakes should now be fixed. R=rnystrom@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=37965

Patch Set 2 : Code review changes. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -4 lines)			Patch
M	pkg/barback/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/graph/transform_node.dart	View	1	5 chunks	+44 lines, -0 lines	0 comments	Download
M	pkg/barback/lib/src/utils.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/barback/pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/code_transformers/lib/src/test_harness.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/code_transformers/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One nit but LGTM. https://codereview.chromium.org/367023003/diff/1/pkg/barback/lib/src/graph/transform_node.dart File pkg/barback/lib/src/graph/transform_node.dart (right): https://codereview.chromium.org/367023003/diff/1/pkg/barback/lib/src/graph/transform_node.dart#newcode632 pkg/barback/lib/src/graph/transform_node.dart:632: new Duration(milliseconds: 200))) { How ...

6 years, 5 months ago (2014-07-02 23:01:20 UTC) #3

nweiz

https://codereview.chromium.org/367023003/diff/1/pkg/barback/lib/src/graph/transform_node.dart File pkg/barback/lib/src/graph/transform_node.dart (right): https://codereview.chromium.org/367023003/diff/1/pkg/barback/lib/src/graph/transform_node.dart#newcode632 pkg/barback/lib/src/graph/transform_node.dart:632: new Duration(milliseconds: 200))) { On 2014/07/02 23:01:20, Bob Nystrom ...

6 years, 5 months ago (2014-07-02 23:53:33 UTC) #5

nweiz

6 years, 5 months ago (2014-07-02 23:54:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r37965 (presubmit successful).

Expand Messages | Collapse Messages