Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 366853005: Mark two pub tests as failing (Closed)

Created:
6 years, 5 months ago by ricow1
Modified:
6 years, 5 months ago
Reviewers:
nweiz, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark two pub tests as failing pub/test/global/deactivate/unexpected_arguments_test pub/test/global/deactivate/missing_package_arg_test Started failing after revision 37915 Filed http://dartbug.com/19784 to track this. I wonder why these did not show up failing running the tests locally (the tests where actually changed) R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=37933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M sdk/lib/_internal/pub/pub.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 5 months ago (2014-07-02 07:22:29 UTC) #1
kasperl
LGTM.
6 years, 5 months ago (2014-07-02 07:26:09 UTC) #2
ricow1
6 years, 5 months ago (2014-07-02 07:26:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37933.

Powered by Google App Engine
This is Rietveld 408576698