Issue 366063002: pkg/shelf: Updated headers map to use pkg/collection CanonicalizedMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 366063002: pkg/shelf: Updated headers map to use pkg/collection CanonicalizedMap (Closed)

Created:
6 years, 5 months ago by kevmoo

Modified:
6 years, 5 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/shelf: Updated headers map to use pkg/collection CanonicalizedMap remove documentation link from pubspec R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=38049

Patch Set 2 : cl nit #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
M	pkg/shelf/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/shelf/lib/src/shelf_unmodifiable_map.dart	View	1	3 chunks	+4 lines, -11 lines	0 comments	Download
M	pkg/shelf/pubspec.yaml	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/366063002/diff/1/pkg/shelf/lib/src/shelf_unmodifiable_map.dart File pkg/shelf/lib/src/shelf_unmodifiable_map.dart (right): https://codereview.chromium.org/366063002/diff/1/pkg/shelf/lib/src/shelf_unmodifiable_map.dart#newcode35 pkg/shelf/lib/src/shelf_unmodifiable_map.dart:35: (key) => key.toLowerCase()); Add an [isValidKey] function that ...

6 years, 5 months ago (2014-07-07 19:59:42 UTC) #2

kevmoo

https://codereview.chromium.org/366063002/diff/1/pkg/shelf/lib/src/shelf_unmodifiable_map.dart File pkg/shelf/lib/src/shelf_unmodifiable_map.dart (right): https://codereview.chromium.org/366063002/diff/1/pkg/shelf/lib/src/shelf_unmodifiable_map.dart#newcode35 pkg/shelf/lib/src/shelf_unmodifiable_map.dart:35: (key) => key.toLowerCase()); On 2014/07/07 19:59:42, nweiz wrote: > ...

6 years, 5 months ago (2014-07-07 23:52:45 UTC) #3

kevmoo

6 years, 5 months ago (2014-07-07 23:53:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38049 (presubmit successful).

Expand Messages | Collapse Messages

Issue 366063002: pkg/shelf: Updated headers map to use pkg/collection CanonicalizedMap (Closed)

Description

Patch Set 1 #

Patch Set 2 : cl nit #

Messages