Issue 365713004: Adjust mirrors/regress_19731_test to avoid static warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365713004: Adjust mirrors/regress_19731_test to avoid static warnings. (Closed)

Created:
6 years, 5 months ago by rmacnak

Modified:
6 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adjust mirrors/regress_19731_test to avoid static warnings. TBR=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=37904

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tests/lib/mirrors/regress_19731_test.dart	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Committed patchset #2 manually as r37904 (presubmit successful).

6 years, 5 months ago (2014-07-01 20:32:41 UTC) #2

regis

LGTM, although I wonder what kind of static warnings you were getting.

6 years, 5 months ago (2014-07-02 15:34:34 UTC) #3

rmacnak

6 years, 5 months ago (2014-07-08 17:19:19 UTC) #4

Message was sent while issue was closed.

On 2014/07/02 15:34:34, regis wrote:
> LGTM, although I wonder what kind of static warnings you were getting.

reflectType's return type is TypeMirror, which does not define declarations. Of
course dynamically we actually get a ClassMirror.

Expand Messages | Collapse Messages