Issue 365663002: Mark mirrors/mirrors_used_inheritance_test as Skip except for dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 365663002: Mark mirrors/mirrors_used_inheritance_test as Skip except for dart2js. (Closed)

Created:
6 years, 5 months ago by herhut

Modified:
6 years, 5 months ago

Reviewers:
ricow1, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark mirrors/mirrors_used_inheritance_test as Skip except for dart2js. BUG= TBR=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=37870

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

herhut

Committed patchset #1 manually as r37870 (presubmit successful).

6 years, 5 months ago (2014-07-01 13:05:33 UTC) #2

herhut

On 2014/07/01 13:13:04, ricow1 wrote: > dbc > > Why skip? To safe on precious ...

6 years, 5 months ago (2014-07-01 13:19:41 UTC) #4

herhut

On 2014/07/01 13:19:41, herhut wrote: > On 2014/07/01 13:13:04, ricow1 wrote: > > dbc > ...

6 years, 5 months ago (2014-07-01 13:32:24 UTC) #5

ricow1

6 years, 5 months ago (2014-07-01 13:37:07 UTC) #6

Message was sent while issue was closed.

On 2014/07/01 13:32:24, herhut wrote:
> On 2014/07/01 13:19:41, herhut wrote:
> > On 2014/07/01 13:13:04, ricow1 wrote:
> > > dbc
> > > 
> > > Why skip?
> > 
> > To safe on precious cycles. It makes no sense to even run the test unless
the
> vm
> > starts supporting @MirrorsUsed.
> 
> Karl convinced me that cycles are not that precious after all. See
> https://codereview.chromium.org/367673002.

So you are right if this was timing out - it is not (you can run 900 tests like
this in the time it takes 1 test to time out)

Expand Messages | Collapse Messages