Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 365193004: Move Index and IndexStore implementations into Engine. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move Index and IndexStore implementations into Engine. Also move most of the related tests. LocalIndex test is commented out, because relies on the infrastucture existing only in Server - virtual file system, mocks. We need to move it into Engine or extract into a separate package. This CL also removes Dart implementation of BTree. We now use a different approach to implementing the index. Bots are red after the previous CL, I hope that this one will fix at least some redness. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37993

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -7489 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analysis_server/lib/src/index/b_plus_tree.dart View 1 chunk +0 lines, -774 lines 0 comments Download
D pkg/analysis_server/lib/src/index/file_page_manager.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D pkg/analysis_server/lib/src/index/index.dart View 1 chunk +0 lines, -115 lines 0 comments Download
D pkg/analysis_server/lib/src/index/lru_cache.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D pkg/analysis_server/lib/src/index/page_node_manager.dart View 1 chunk +0 lines, -461 lines 0 comments Download
D pkg/analysis_server/lib/src/index/store/codec.dart View 1 chunk +0 lines, -216 lines 0 comments Download
D pkg/analysis_server/lib/src/index/store/collection.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D pkg/analysis_server/lib/src/index/store/separate_file_manager.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/analysis_server/lib/src/index/store/split_store.dart View 1 chunk +0 lines, -898 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +2 lines, -1 line 1 comment Download
M pkg/analysis_server/test/analysis_abstract.dart View 8 chunks +94 lines, -94 lines 0 comments Download
M pkg/analysis_server/test/domain_search_test.dart View 3 chunks +4 lines, -5 lines 0 comments Download
D pkg/analysis_server/test/index/b_plus_tree_test.dart View 1 chunk +0 lines, -686 lines 0 comments Download
D pkg/analysis_server/test/index/file_page_manager_test.dart View 1 chunk +0 lines, -125 lines 0 comments Download
D pkg/analysis_server/test/index/index_test.dart View 1 chunk +0 lines, -179 lines 0 comments Download
D pkg/analysis_server/test/index/lru_cache_test.dart View 1 chunk +0 lines, -99 lines 0 comments Download
D pkg/analysis_server/test/index/page_node_manager_test.dart View 1 chunk +0 lines, -434 lines 0 comments Download
D pkg/analysis_server/test/index/store/codec_test.dart View 1 chunk +0 lines, -178 lines 0 comments Download
D pkg/analysis_server/test/index/store/collection_test.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D pkg/analysis_server/test/index/store/memory_node_manager.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D pkg/analysis_server/test/index/store/separate_file_manager_test.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D pkg/analysis_server/test/index/store/single_source_container.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D pkg/analysis_server/test/index/store/split_store_test.dart View 1 chunk +0 lines, -1066 lines 0 comments Download
D pkg/analysis_server/test/index/store/test_all.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/analysis_server/test/index/store/typed_mocks.dart View 1 chunk +0 lines, -143 lines 0 comments Download
D pkg/analysis_server/test/index/test_all.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/operation/operation_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A + pkg/analysis_server/test/typed_mocks.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D pkg/analyzer/lib/src/index/index.dart View 1 chunk +0 lines, -1193 lines 0 comments Download
A + pkg/analyzer/lib/src/index/index_contributor.dart View 3 chunks +21 lines, -1 line 0 comments Download
A + pkg/analyzer/lib/src/index/local_index.dart View 5 chunks +19 lines, -30 lines 0 comments Download
A + pkg/analyzer/lib/src/index/store/codec.dart View 3 chunks +11 lines, -11 lines 0 comments Download
A + pkg/analyzer/lib/src/index/store/collection.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + pkg/analyzer/lib/src/index/store/memory_node_manager.dart View 1 chunk +6 lines, -5 lines 0 comments Download
A + pkg/analyzer/lib/src/index/store/separate_file_manager.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + pkg/analyzer/lib/src/index/store/split_store.dart View 7 chunks +25 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/search/search_engine.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download
A pkg/analyzer/test/index/local_index_test.dart View 1 chunk +162 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/index/store/codec_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
A + pkg/analyzer/test/index/store/collection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/analyzer/test/index/store/separate_file_manager_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + pkg/analyzer/test/index/store/single_source_container.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/test/index/store/split_store_test.dart View 17 chunks +40 lines, -40 lines 0 comments Download
A + pkg/analyzer/test/index/store/test_all.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analyzer/test/index/store/typed_mocks.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/analyzer/test/index/test_all.dart View 2 chunks +3 lines, -11 lines 0 comments Download
A + pkg/analyzer/test/reflective_tests.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analyzer/test/search/search_engine_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 5 months ago (2014-07-03 20:46:24 UTC) #1
Brian Wilkerson
I'm not sure I like the idea of moving the virtual file system into engine, ...
6 years, 5 months ago (2014-07-03 21:06:33 UTC) #2
Brian Wilkerson
https://codereview.chromium.org/365193004/diff/1/pkg/analysis_server/pubspec.yaml File pkg/analysis_server/pubspec.yaml (right): https://codereview.chromium.org/365193004/diff/1/pkg/analysis_server/pubspec.yaml#newcode10 pkg/analysis_server/pubspec.yaml:10: path: /Users/scheglov/Source/Dart/dart/pkg/analyzer This definitely needs to be backed out.
6 years, 5 months ago (2014-07-03 21:06:46 UTC) #3
scheglov
6 years, 5 months ago (2014-07-03 21:30:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r37993 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698