Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 365043002: Add ResolutionResult as intermediate value in ResolutionVisitor and use it to mark assert. (Closed)

Created:
6 years, 5 months ago by Johnni Winther
Modified:
6 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add ResolutionResult as intermediate value in ResolutionVisitor and use it to mark assert. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=37981

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -44 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 19 chunks +84 lines, -42 lines 4 comments Download
M tests/compiler/dart2js/resolver_test.dart View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
6 years, 5 months ago (2014-07-03 08:23:23 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/365043002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/365043002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2377 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2377: Element target; Target could be a ResolutionResult. https://codereview.chromium.org/365043002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2446 ...
6 years, 5 months ago (2014-07-03 08:36:04 UTC) #2
Johnni Winther
https://codereview.chromium.org/365043002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/365043002/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2377 sdk/lib/_internal/compiler/implementation/resolution/members.dart:2377: Element target; On 2014/07/03 08:36:04, karlklose wrote: > Target ...
6 years, 5 months ago (2014-07-03 12:11:36 UTC) #3
Johnni Winther
6 years, 5 months ago (2014-07-03 12:16:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r37981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698