Fix more pub bugs.

Fix more pub bugs.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37968

[Bob Nystrom, 2014-07-03 01:16:35]

Trying to unbreak the bots. :(

[Siggi Cherem (dart-lang), 2014-07-03 01:17:20]

lgtm

[Bob Nystrom, 2014-07-03 01:18:13]

Committed patchset #1 manually as r37968 (presubmit successful).

[nweiz, 2014-07-07 19:57:18]

https://codereview.chromium.org/364973002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command.dart (right):

https://codereview.chromium.org/364973002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command.dart:231: void usageError(String message)
{
Does this shadow [usageError] in utils? That seems weird. Where is it important
that we eagerly bind the usage? Can we do this explicitly there?

[Bob Nystrom, 2014-07-07 21:03:00]

https://codereview.chromium.org/364973002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/command.dart (right):

https://codereview.chromium.org/364973002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/command.dart:231: void usageError(String message)
{
On 2014/07/07 19:57:18, nweiz wrote:
> Does this shadow [usageError] in utils? That seems weird.

Yeah. :(

> Where is it important that we eagerly bind the usage? Can we do this
explicitly there?

The help command and the top level command routing code both throw usageErrors()
for specific command objects. For the former, you want usage for the failed
command, not the help command itself. For the latter, you aren't inside a
command, so the lazy binding won't happen.

I think the right thing to do is ditch the lazy usage binding I added. I did
that so that you could throw a usageError() outside of the context of a command
(in executable.dart), but I think it's simpler to just pass in the command to
that.

I'll send out a patch.