Issue 364823003: Split the listing of pkg dart files in two targets.

Issue 364823003: Split the listing of pkg dart files in two targets. (Closed)

Created:
6 years, 5 months ago by ricow1

Modified:
6 years, 5 months ago

Reviewers:
ahe, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Split the listing of pkg dart files in two targets. Mac is no liking the long command line we get. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=37946

Patch Set 4 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	pkg/pkg_files.gyp	View	1 2 3	1 chunk	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/364823003/diff/1/pkg/pkg_files.gyp File pkg/pkg_files.gyp (right): https://codereview.chromium.org/364823003/diff/1/pkg/pkg_files.gyp#newcode56 pkg/pkg_files.gyp:56: Stray line?

6 years, 5 months ago (2014-07-02 11:07:29 UTC) #2

ricow1

https://codereview.chromium.org/364823003/diff/1/pkg/pkg_files.gyp File pkg/pkg_files.gyp (right): https://codereview.chromium.org/364823003/diff/1/pkg/pkg_files.gyp#newcode56 pkg/pkg_files.gyp:56: On 2014/07/02 11:07:29, Bill Hesse wrote: > Stray line? ...

6 years, 5 months ago (2014-07-02 11:09:55 UTC) #3

ahe

https://codereview.chromium.org/364823003/diff/20001/pkg/pkg_files.gyp File pkg/pkg_files.gyp (right): https://codereview.chromium.org/364823003/diff/20001/pkg/pkg_files.gyp#newcode15 pkg/pkg_files.gyp:15: 'third_party_pkg_files_stamp', Remove this. https://codereview.chromium.org/364823003/diff/20001/pkg/pkg_files.gyp#newcode38 pkg/pkg_files.gyp:38: 'actions': [ No need ...

6 years, 5 months ago (2014-07-02 12:31:25 UTC) #4

ricow1

Thanks https://codereview.chromium.org/364823003/diff/20001/pkg/pkg_files.gyp File pkg/pkg_files.gyp (right): https://codereview.chromium.org/364823003/diff/20001/pkg/pkg_files.gyp#newcode15 pkg/pkg_files.gyp:15: 'third_party_pkg_files_stamp', On 2014/07/02 12:31:25, ahe wrote: > Remove ...

6 years, 5 months ago (2014-07-02 12:40:17 UTC) #5

ricow1

6 years, 5 months ago (2014-07-02 13:48:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r37946 (presubmit successful).

Expand Messages | Collapse Messages