Issue 36453002: fix template_binding tests on safari/ie

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 36453002: fix template_binding tests on safari/ie (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly

Modified:
7 years, 2 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix template_binding tests on safari/ie TemplateElement is not supported on these platforms * * in Polymer, the ShadowDOM polyfill takes care of this so it will work okay. BUG= Committed: https://code.google.com/p/dart/source/detail?r=29059

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -12 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/template_binding/test/element_bindings_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/template_binding/test/template_element_test.dart	View	4 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

tbr ... sigh, there's no way to test this on Linux as all browsers support ...

7 years, 2 months ago (2013-10-23 03:58:25 UTC) #1

Jennifer Messerly

Committed patchset #1 manually as r29059 (presubmit successful).

7 years, 2 months ago (2013-10-23 03:59:27 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages