Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 363573002: Add a line to pub usage output explaining how to see global options. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a line to pub usage output explaining how to see global options. R=rnystrom@google.com BUG=17252 Committed: https://code.google.com/p/dart/source/detail?r=37915

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M sdk/lib/_internal/pub/lib/src/command.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/missing_package_arg_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/cache/add/unexpected_arguments_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/bad_version_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/missing_package_arg_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/global/activate/unexpected_arguments_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/lish/force_cannot_be_combined_with_dry_run_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_test.dart View 1 13 chunks +16 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/pub_uploader_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/run/errors_if_no_executable_is_given_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/test/run/errors_if_path_in_dependency_test.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 5 months ago (2014-07-01 01:10:59 UTC) #1
Bob Nystrom
One suggestion but LGTM either way. https://codereview.chromium.org/363573002/diff/1/sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart File sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart (right): https://codereview.chromium.org/363573002/diff/1/sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart#newcode22 sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart:22: Use "pub help" ...
6 years, 5 months ago (2014-07-01 17:10:59 UTC) #2
nweiz
https://codereview.chromium.org/363573002/diff/1/sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart File sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart (right): https://codereview.chromium.org/363573002/diff/1/sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart#newcode22 sdk/lib/_internal/pub/test/cache/add/bad_version_test.dart:22: Use "pub help" to see global options. On 2014/07/01 ...
6 years, 5 months ago (2014-07-01 22:06:59 UTC) #3
nweiz
6 years, 5 months ago (2014-07-01 22:07:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37915 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698