Hide synthetic metadata field exposed in r35926.

Hide synthetic metadata field exposed in r35926.

Also remove Object::CreateInternalMetaData.

BUG=http://dartbug.com/19731
R=iposva@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37900

[regis, 2014-06-30 22:59:47]

LGTM

[Ivan Posva, 2014-07-01 14:27:49]

LGTM, while at the same timeI am wondering whether this cannot be dealt with
entirely within the mirrors.cc code.

-Ivan

https://codereview.chromium.org/363473004/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/363473004/diff/1/runtime/lib/mirrors.cc#newco...
runtime/lib/mirrors.cc:1060: if (!field.is_synthetic()) {
Do we need this extra field in the Field or can't we just base it on the name?

https://codereview.chromium.org/363473004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/363473004/diff/1/runtime/vm/object.cc#newcode799
runtime/vm/object.cc:799: void Object::CreateInternalMetaData() {
Please evaluate whether this is function is still needed. I expect this can be
entirely deleted.

https://codereview.chromium.org/363473004/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:1391: field = Field::New(field_name, true, false, true,
false, cls, 0);            \
These fields are synthetic, no?

[rmacnak, 2014-07-01 20:08:20]

https://codereview.chromium.org/363473004/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/363473004/diff/1/runtime/lib/mirrors.cc#newco...
runtime/lib/mirrors.cc:1060: if (!field.is_synthetic()) {
On 2014/07/01 14:27:48, Ivan Posva wrote:
> Do we need this extra field in the Field or can't we just base it on the name?

Will consider this in a follow up CL. FWIW this does not increase the size of a
Field.

https://codereview.chromium.org/363473004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/363473004/diff/1/runtime/vm/object.cc#newcode799
runtime/vm/object.cc:799: void Object::CreateInternalMetaData() {
On 2014/07/01 14:27:48, Ivan Posva wrote:
> Please evaluate whether this is function is still needed. I expect this can be
> entirely deleted.

I don't see any other references to @parent. Removed.

https://codereview.chromium.org/363473004/diff/1/runtime/vm/object.cc#newcode...
runtime/vm/object.cc:1391: field = Field::New(field_name, true, false, true,
false, cls, 0);            \
On 2014/07/01 14:27:49, Ivan Posva wrote:
> These fields are synthetic, no?

They are accessed from Dart code, so no.

[rmacnak, 2014-07-01 20:09:16]

Committed patchset #2 manually as r37900 (presubmit successful).