IndexStore, Index and SearchEngine APIs and partial implementatons.

IndexStore, Index and SearchEngine APIs and partial implementatons.

IndexStore and Index implementations are not moved yet to engine package.

SearchEngine implementation is not cleaned up yet, there is only (commented) raw java2dart translation result.

Index contributions are present, but without tests yet.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=37991

[Brian Wilkerson, 2014-07-03 18:58:13]

LGTM

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/search/sear...
File pkg/analyzer/lib/search/search_engine.dart (right):

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/search/sear...
pkg/analyzer/lib/search/search_engine.dart:391: bool operator ==(Object obj) {
nit: "obj" --> "object"

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/search/sear...
pkg/analyzer/lib/search/search_engine.dart:398: SearchMatch o = obj as
SearchMatch;
nit: "o" --> "match"

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
File pkg/analyzer/lib/src/index/index.dart (right):

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
pkg/analyzer/lib/src/index/index.dart:160: SimpleIdentifier identifier =
expression;
I'm not sure what the value of this local variable is: 'expression' already has
the type 'SimpleIdentifier' within the then-statement.

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
pkg/analyzer/lib/src/index/index.dart:247: * Recursively visits [HtmlUnit] and
every embedded [Expression].
"visits" --> "visits an"

[scheglov, 2014-07-03 19:06:17]

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/search/sear...
File pkg/analyzer/lib/search/search_engine.dart (right):

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/search/sear...
pkg/analyzer/lib/search/search_engine.dart:391: bool operator ==(Object obj) {
On 2014/07/03 18:58:13, Brian Wilkerson wrote:
> nit: "obj" --> "object"

Done.

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
File pkg/analyzer/lib/src/index/index.dart (right):

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
pkg/analyzer/lib/src/index/index.dart:160: SimpleIdentifier identifier =
expression;
On 2014/07/03 18:58:13, Brian Wilkerson wrote:
> I'm not sure what the value of this local variable is: 'expression' already
has
> the type 'SimpleIdentifier' within the then-statement.

Fixed.

Should it be a hint?

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
pkg/analyzer/lib/src/index/index.dart:247: * Recursively visits [HtmlUnit] and
every embedded [Expression].
On 2014/07/03 18:58:13, Brian Wilkerson wrote:
> "visits" --> "visits an"

Done.

[scheglov, 2014-07-03 19:06:40]

Committed patchset #1 manually as r37991 (presubmit successful).

[Brian Wilkerson, 2014-07-03 20:48:19]

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
File pkg/analyzer/lib/src/index/index.dart (right):

https://codereview.chromium.org/363373002/diff/1/pkg/analyzer/lib/src/index/i...
pkg/analyzer/lib/src/index/index.dart:160: SimpleIdentifier identifier =
expression;
> Should it be a hint?

Perhaps. If the original variable and the new variable are never re-assigned
within the block there shouldn't be any false positives.