Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 363223003: Revert "Emit declarations for typedefs that are needed by reflection." (Closed)

Created:
6 years, 5 months ago by karlklose
Modified:
6 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Emit declarations for typedefs that are needed by reflection." Does not work in csp-drt. This reverts commit r37945. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -158 lines) Patch
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 12 chunks +22 lines, -55 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/metadata_emitter.dart View 1 chunk +14 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/_internal/compiler/implementation/runtime_data.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/world.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 4 chunks +25 lines, -26 lines 0 comments Download
M tests/compiler/dart2js/analyze_unused_dart2js_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +1 line, -2 lines 0 comments Download
M tests/lib/mirrors/relation_subclass_test.dart View 1 chunk +7 lines, -6 lines 0 comments Download
D tests/lib/mirrors/typedef_declaration_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
6 years, 5 months ago (2014-07-03 07:23:52 UTC) #1
karlklose
Committed patchset #1 manually as r37973 (presubmit successful).
6 years, 5 months ago (2014-07-03 07:24:23 UTC) #2
Johnni Winther
6 years, 5 months ago (2014-07-03 07:36:21 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698