Issue 363113004: Handle unresolved elements in the new IR

Issue 363113004: Handle unresolved elements in the new IR (Closed)

Created:
6 years, 5 months ago by sigurdm

Modified:
6 years, 5 months ago

Reviewers:
asgerf, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle unresolved elements in the new IR Also handle static calls to identical. It seems the renamer takes care of these - mostly we just have to not give up. R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=37977

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -34 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart	View	1	9 chunks	+6 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

asgerf

Nice! LGTM https://codereview.chromium.org/363113004/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/363113004/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode1377 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1377: Elements.isUnresolved(element)) || isErroneousElement can make the check ...

6 years, 5 months ago (2014-07-03 07:43:40 UTC) #2

sigurdm

https://codereview.chromium.org/363113004/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/363113004/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode1377 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:1377: Elements.isUnresolved(element)) || On 2014/07/03 07:43:39, asgerf wrote: > isErroneousElement ...

6 years, 5 months ago (2014-07-03 08:45:02 UTC) #3

sigurdm

6 years, 5 months ago (2014-07-03 08:51:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r37977 (presubmit successful).

Expand Messages | Collapse Messages