Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 362893004: Implementation for 'analysis.getHover'. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implementation for 'analysis.getHover'. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=37952

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fixes for review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -15 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 8 chunks +12 lines, -12 lines 0 comments Download
A pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 1 chunk +162 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 5 chunks +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +32 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +2 lines, -1 line 0 comments Download
A pkg/analysis_server/test/analysis_hover_test.dart View 1 1 chunk +191 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 5 months ago (2014-07-02 05:12:43 UTC) #1
Brian Wilkerson
LGTM, but there is *way* too much churn. Also, I thought Dan was working on ...
6 years, 5 months ago (2014-07-02 13:58:06 UTC) #2
scheglov
https://codereview.chromium.org/362893004/diff/1/pkg/analysis_server/lib/src/analysis_server.dart File pkg/analysis_server/lib/src/analysis_server.dart (right): https://codereview.chromium.org/362893004/diff/1/pkg/analysis_server/lib/src/analysis_server.dart#newcode90 pkg/analysis_server/lib/src/analysis_server.dart:90: final Map<Folder, AnalysisContext> folderMap = new HashMap<Folder, On 2014/07/02 ...
6 years, 5 months ago (2014-07-02 17:33:10 UTC) #3
scheglov
6 years, 5 months ago (2014-07-02 17:33:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r37952 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698